search

Princeton-CDH / bitKlavier

The piano, digitally reinvented.
http://bitklavier.com/
GNU General Public License v3.0
37 stars 5 forks source link

Nostalgic SynchronicSyncMode quirkiness #23

Closed mulshine closed 7 years ago

mulshine commented 8 years ago

Variable behavior. Try setting beatsToSkip to 5 and tapping notes (and Synchronic numPulses to 10 or so to hear the pulse).

I think this has something to do with the SynchronicProcessor phasor/beatLength not being updated before nostalgic keyPressed is received.

dantrueman commented 7 years ago

are you talking about the fact that the nostalgic note peak with at unpredictable times? it's a little hard to fully test without having the keymap in place, since every note i play resets the synchronic phase. but, if i hard-code the keymap so only noteNumber == 60 activates in SynchronicProcessor::keyPressed, then the behavior seems to be fine. i think.

mulshine commented 7 years ago

The keymap is in place for testing - have you pulled from the dev branch?

On Sat, Dec 3, 2016 at 11:32 PM dantrueman notifications@github.com wrote:

are you talking about the fact that the nostalgic note peak with at unpredictable times? it's a little hard to fully test without having the keymap in place, since every note i play resets the synchronic phase. but, if i hard-code the keymap so only noteNumber == 60 activates in SynchronicProcessor::keyPressed, then the behavior seems to be fine. i think.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/23#issuecomment-264683830, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlRgPaf6KqprZL0Wu70kVrGMz63iAeQks5rEkJsgaJpZM4LC3Go .

dantrueman commented 7 years ago

i did pull from dev. how do you use it?

The keymap is in place for testing - have you pulled from the dev branch?

mulshine commented 7 years ago

oh! basically treat the keymap text field as the midi not numbers in the keymap.

60 62 64 would be C4 D4 E4

as basic as it gets so far!

youd have to copy in all the values between 0 and 128 or 9 and 98 tonget all keys

On Sun, Dec 4, 2016 at 12:07 AM dantrueman notifications@github.com wrote:

i did pull from dev. how do you use it?

The keymap is in place for testing - have you pulled from the dev branch?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/23#issuecomment-264684846, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlRgD_4-DRbiQoirAQ0CacLTljo0ek0ks5rEkp5gaJpZM4LC3Go .

dantrueman commented 7 years ago

i figured, but it didn't work. i'll look through the code to see if i can figure it out...

dantrueman commented 7 years ago

the callback:

else if (name == "SynchronicKeymap") {

}

in SynchronicViewController::textFieldDidChange is unimplemented... maybe you didn't push the final working version?

mulshine commented 7 years ago

oh shoot! may have only commited. my bad

On Sun, Dec 4, 2016 at 8:24 AM dantrueman notifications@github.com wrote:

the callback:

else if (name == "SynchronicKeymap") {

}

in SynchronicViewController::textFieldDidChange is unimplemented... maybe you didn't push the final working version?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Princeton-CDH/bitKlavier/issues/23#issuecomment-264703800, or mute the thread https://github.com/notifications/unsubscribe-auth/AGlRgBDjrLpstSOjeif3VW2DDT6oMiVGks5rEr8hgaJpZM4LC3Go .