search

Princeton-CDH / bitKlavier

The piano, digitally reinvented.
http://bitklavier.com/
GNU General Public License v3.0
37 stars 5 forks source link

Minimal clicking when playing TONS of notes with pedal down #36

Closed mulshine closed 7 years ago

mulshine commented 7 years ago

If I keep the pedal down and play literally hundreds of notes within a span of 5-10 seconds, there are a few clicks here and there... lol. This may not be an issue, but it might also be worth trying to get rid of early on.

It may just be that we haven't thought of any particular cases in which having the pedal down may change the way we trigger samples.

dantrueman commented 7 years ago

i haven’t looked at how JUCE handles the pedal, so we’ll want to make sure currently sounding notes are shut off when the pedal is down. we ran into this problem with the current version, and the fix was easy and made a big impact.

On Dec 15, 2016, at 10:04 AM, Mike Mulshine notifications@github.com<mailto:notifications@github.com> wrote:

If I keep the pedal down and play like hundreds of notes within in the span of 5-10 seconds, there are clicks... This may not be an issue, but it might also be worth trying to get rid of early on.

It may just be that we haven't thought of any particular cases in which having the pedal down may change the way we trigger samples.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Princeton-CDH/bitKlavier/issues/36, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKpmtvLn-7iYXCHZmXQvXJWIpSjPHgRtks5rIVcDgaJpZM4LOMYE.