Princeton-LSI-ResearchComputing / tracebase

Mouse Metabolite Tracing Data Repository for the Rabinowitz Lab
MIT License
4 stars 1 forks source link

Enhance data integrity of animal and sample entries #754

Open lparsons opened 11 months ago

lparsons commented 11 months ago

FEATURE REQUEST

Inspiration

When loading new data we rely on the researchers to clearly and uniquely label animal and sample records. While animal records contain various metadata attributes that reduce the chance of duplicate/incorrect entries, samples are more difficult to identify. It is important to ensure a sample is associated with the correct animal. When loading data files, matching to the correct sample becomes more difficult since we can match only on name.

Description

If multiple animal or sample records differ by only the name, they are likely duplicates and this should be flagged during loading. In addition, when loading data files we should require an associated sample sheet to ensure that we associate the data to the correct sample records by checking that the metadata matches (in addition to simply the sample name).

Alternatives

None

Dependencies

This issue cannot be started until the completion of the following issue(s)/ pull request(s):

Comment

None


ISSUE OWNER SECTION

Assumptions

  1. List of assumptions that the code will not explicitly address/check
  2. E.g. We will assume input is correct (explaining why there is no validation)

Limitations

  1. A list of things this work will specifically not do
  2. E.g. This feature will only handle the most frequent use case X

Affected Components

Requirements

DESIGN

Interface Change description

None provided

Code Change Description

None provided

Tests

hepcat72 commented 11 months ago

I edited #577 to bring it up to date. Much of the issue was outdated, but the spirit of the feature change was not yet fully implemented.