PrincetonUniversity / SPEC

The Stepped-Pressure Equilibrium Code, an advanced MRxMHD equilibrium solver.

https://princetonuniversity.github.io/SPEC/

GNU General Public License v3.0

25 stars 6 forks source link

fixed fixed-boundary Igeometry=2 error #53

Closed zhisong closed 6 years ago

zhisong commented 6 years ago

52 An if condition added to preset.h to jump operations irrelevant to fixed-boundary.

A test input file attached (plz remove the .txt extension). cyl.sp.txt

jloizu commented 6 years ago

I tested this branch (compilation and execution of both cylindrical test case and stellarator test case, fixed and free boundary) and everything works fine.

You can merge into master (unless you want someone else to test as well).

jloizu commented 6 years ago

Just realized that your branch cyfix was not up-to-date with master. You did not pull the master branch in a long time (since Aug 22 I believe). So I am not sure how the merging works in this case. I hope and guess that the master commits will be robust and only your change will be applied to the newest master branch. Please be sure of that before you merge.

zhisong commented 6 years ago

Git is smart. As long as there is no conflict, it will just apply the modification to the master branch.