PrintMakerLab / mks-wifi-plugin

MKS wifi plugin for Cura
https://marketplace.ultimaker.com/app/cura/plugins/Jeredian/MKSWifiPlugin
GNU Affero General Public License v3.0
140 stars 56 forks source link

feat: add webcam experimental feature #410

Closed BigIskander closed 8 months ago

BigIskander commented 8 months ago

Description

Added a new feature. This feature adds the view from web camera in Monitor Tab. Stream URL can be set from Advanced settings tab in settings window. It works with URL like this: http://ip/webcam/?action=stream .

This feature dresses issue number 167: https://github.com/PrintMakerLab/mks-wifi-plugin/issues/167

Type of change

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior(if this is a feature change)?

How has this been tested?

I tested this feature in my local network with camera video stream from MJPG-Streamer and URL like this http://camera_ip:port/?action=stream .

Снимок экрана от 2024-03-05 19-29-57

Снимок экрана от 2024-03-05 19-30-12

Does this PR introduce a breaking change?

Does it closes one of the existing issues?

closes #167

Other information

PR Checklist:

Jeredian commented 8 months ago

@BigIskander , thank you for submitting the pull request. Could you add the screenshots of advanced settings tab and what it looks like when the webcam is streaming (screenshot of the monitor tab) ?

BigIskander commented 8 months ago

@BigIskander , thank you for submitting the pull request. Could you add the screenshots of advanced settings tab and what it looks like when the webcam is streaming (screenshot of the monitor tab) ?

Added screenshots.

Jeredian commented 8 months ago

Tested on Cura 5.5 for macOS

image image

Jeredian commented 8 months ago

@BigIskander , any updates?

BigIskander commented 8 months ago

@BigIskander , any updates?

No, I didn't have enough free time lately. I will try to change code according with your recommendations later.

BigIskander commented 8 months ago

@BigIskander , any updates?

Changed the code, made new git commit.

BigIskander commented 8 months ago

We need to polish up the PR with a simple cleanup.

Made simple clean up, made new git commit.

sonarcloud[bot] commented 8 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 8 months ago

The content of this pull request will be made available as part of our next release.