Closed BigIskander closed 8 months ago
@BigIskander , thank you for submitting the pull request. Could you add the screenshots of advanced settings tab and what it looks like when the webcam is streaming (screenshot of the monitor tab) ?
@BigIskander , thank you for submitting the pull request. Could you add the screenshots of advanced settings tab and what it looks like when the webcam is streaming (screenshot of the monitor tab) ?
Added screenshots.
Tested on Cura 5.5 for macOS
@BigIskander , any updates?
@BigIskander , any updates?
No, I didn't have enough free time lately. I will try to change code according with your recommendations later.
@BigIskander , any updates?
Changed the code, made new git commit.
We need to polish up the PR with a simple cleanup.
Made simple clean up, made new git commit.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
The content of this pull request will be made available as part of our next release.
Description
Added a new feature. This feature adds the view from web camera in Monitor Tab. Stream URL can be set from Advanced settings tab in settings window. It works with URL like this: http://ip/webcam/?action=stream .
This feature dresses issue number 167: https://github.com/PrintMakerLab/mks-wifi-plugin/issues/167
Type of change
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior(if this is a feature change)?
How has this been tested?
I tested this feature in my local network with camera video stream from MJPG-Streamer and URL like this http://camera_ip:port/?action=stream .
Does this PR introduce a breaking change?
Does it closes one of the existing issues?
closes #167
Other information
PR Checklist: