PrishaVP / pe

0 stars 0 forks source link

Overzealous input validation for phone number #6

Open PrishaVP opened 1 week ago

PrishaVP commented 1 week ago

I may want to save people from different countries (especially donors because often rich business people donors may be situated in other countries) hence the + symbol should be supported. Furthermore, some countries phone numbers have brackets (area code). People may also want to use - and spaces between long numbers for better readability. All these give this error message.

Screenshot 2024-11-15 at 5.06.25 PM.png

soc-pe-bot commented 4 days ago

Team's Response

Thank you for pointing that out.

The current implementation of phone number validation enforces simplicity by allowing only numeric values. This decision was made with our target users—small NGO administrators—in mind. These users primarily manage local contacts, meaning that the vast majority of phone numbers do not require symbols like +, spaces, or brackets for international formatting.

Given that the application's scope is tailored to meet the needs of small NGOs with predominantly local contacts (up to 8 digits only as well), the current validation approach aligns with its intended use. Adding support for international formatting would add unnecessary complexity for a feature that is unlikely to see frequent use among our target users.

As such, we categorise this issue as NotInScope for the current version. However, we appreciate the feedback and may consider revisiting this in future iterations should the need for international phone numbers arise.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]