search

PrismLibrary / Prism

Prism is a framework for building loosely coupled, maintainable, and testable XAML applications in WPF, Xamarin Forms, and Uno / Win UI Applications..
Other
6.36k stars 1.64k forks source link

Can the DirectoryModuleCatalog lookup DLL be changed to all subdirectories? #2930

Open BoyFaceGirl opened 1 year ago

BoyFaceGirl commented 1 year ago

Summary

https://github.com/PrismLibrary/Prism/blob/bf0966af97a7dd16141ed3b3c3cfc784ff5e0cb7/src/Wpf/Prism.Wpf/Modularity/DirectoryModuleCatalog.netcore.cs#L102C33-L102C51

The module DLL may exist in some subdirectories, and the current search method cannot find the DLL

e.g.

var fileInfos = directory.GetFiles("*.dll",SearchOption.AllDirectories)

brianlagunas commented 1 year ago

This would not be implemented as you have here, but maybe via an exposed property to control the options. Would you like to submit a PR?