Closed extremeheat closed 1 month ago
The packet_explosion
was broken since 1.20.3, fixed
ChatTypes
type was wrong, it's either an ID or encoded inline (and your proposed fix in PR is incorrect), just fixed.
https://github.com/PrismarineJS/mineflayer/pull/3480 chat back at being broken after the change here
Should I undo https://github.com/PrismarineJS/prismarine-registry/pull/42 ?
Trying
The
packet_explosion
was broken since 1.20.3, fixed
ChatTypes
type was wrong, it's either an ID or encoded inline (and your proposed fix in PR is incorrect), just fixed.
lol I just fixed the packet_explosion in my pr too, I'm going to pull your changes then
PrismarineJS/mineflayer#3480 chat back at being broken after the change here
Should I undo PrismarineJS/prismarine-registry#42 ?
No same if not using the change at prismarine registry
Chat is timing out
We need another change
Also, wolf_variant metadata is broken
Also, wolf_variant metadata is broken
wild_texture
seems to work the same as soundId
in packet_explosion
, if I set its type to varint I get the numeric identifier of its texture + 1. However, the other fields seem to be optional/missing I'm not sure.
PrismarineJS/mineflayer#3480 chat back at being broken after the change here Should I undo PrismarineJS/prismarine-registry#42 ?
No same if not using the change at prismarine registry
Chat is timing out
We need another change
my bad, should've made a note
PrismarineJS/prismarine-registry#42 now requires PrismarineJS/minecraft-data#932
@GroobleDierne "pickaxe not upside-down recipe test" is failing, can you check it?
@extremeheat
packet explosion seems to have issues
1) packets 1.20.6v
play,ClientBound,packet_explosion:
TypeError: Cannot convert undefined or null to object
at Function.keys (
@GroobleDierne "pickaxe not upside-down recipe test" is failing, can you check it?
I'll look into that tomorrow
so the problem was that missing items in recipes should be null; not -1 I fixed it with a replace; can you fix it in the extractor @GroobleDierne ?
so the problem was that missing items in recipes should be null; not -1 I fixed it with a replace; can you fix it in the extractor @GroobleDierne ?
Yep I also updated the sounds generator for 1.21 this afternoon, I'll upstream everything.
/makerelease
@extremeheat are you still working on this? I did some testing by connecting a nmp client using your protocol.json to a 1.21 server and some clientbound packets aren't processed successfully. If it can be of any help, here are the errors I encountered:
When detonating a TNT next to the playerfixedWhen joining the serverFixed in https://github.com/PrismarineJS/minecraft-data/pull/927And player_chat and profileless_chat related errors that I fixed in #927