PriyaGhosal / BuddyTrail

This repository is officially part of GirlScript Summer of Code 2024 Extended Edition !
https://buddytrail.netlify.app/
MIT License
132 stars 348 forks source link

Add a Responsive pop up dialog box for subscribing to newsletter done ! #1923 #1924

Open Subhajit-2023-44 opened 1 month ago

Subhajit-2023-44 commented 1 month ago

Hello, PR Fixed issue - #1923

Now after signing up this popup will not show anymore..

Screenshot 2024-11-06 022528

I first tried doing this on the existing popup but it had so many issues, the whole thing had to be changed. So I added a new popup..

Type of PR

Checklist:

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2024 3:43pm
github-actions[bot] commented 1 month ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

netlify[bot] commented 1 month ago

Deploy Preview for buddytrail ready!

Name Link
Latest commit 41bcb0a0cf2f90ee09f3d7c7b575f35efec00819
Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6730d4a20a038c00097edd84
Deploy Preview https://deploy-preview-1924--buddytrail.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Subhajit-2023-44 commented 1 month ago

I added a new Responsive pop up dialog box for subscribing to newsletter, because the existing popup is not responsive, I first tried doing this on the existing popup but it had so many issues, the whole thing had to be changed. So I added a new popup..

Now after signing up this popup will not show anymore..

@PriyaGhosal please merge my PR

Thank you

Subhajit-2023-44 commented 1 month ago

@PriyaGhosal

PriyaGhosal commented 1 month ago

@Subhajit-2023-44 Please see the conflicts

Subhajit-2023-44 commented 1 month ago

@Subhajit-2023-44 Please see the conflicts

now time is over 😭