ProNooberEX / endless-sky

Space exploration, trading, and combat game.
https://endless-sky.github.io/
GNU General Public License v3.0
0 stars 0 forks source link

Conversation on the Missions #1

Open TheGiraffe3 opened 2 weeks ago

TheGiraffe3 commented 2 weeks ago

Start the issue

TheGiraffe3 commented 2 weeks ago

Would you like me to make a pull request, or for us to both work on the main branch?

ProNooberEX commented 2 weeks ago

I fine with both, you can choose which is more preferable to you.

TheGiraffe3 commented 2 weeks ago

It would be easier if I could add labels, definitely. But that requires me being an admin and being able to change anything in this repository. If you’re okay with that, go to Settings, click Collaborators, and send me an invite.

ProNooberEX commented 2 weeks ago

Added you

TheGiraffe3 commented 2 weeks ago

I’ve created a new file for the campaign. Normally what I (cheat) and do is copy a mission from the main game, add that, and then edit it. I’ll start the first mission now.

ProNooberEX commented 2 weeks ago

I have added an additional choice to beginning spaceport event with the knife

ProNooberEX commented 2 weeks ago

Btw I find it is getting messy seeing all of the choices and their sub branches, is there a way for me to view these branches on a more organized level?

TheGiraffe3 commented 2 weeks ago

Not in GitHub. There’s an application called Visual Studio Code that allows you to do that though. I don’t remember if it’s available on the App Store, but here’s the website.

ProNooberEX commented 2 weeks ago

I have VSC on my mac, should I download the code file onto it and edit it there?

TheGiraffe3 commented 2 weeks ago

Probably. There is some fancy thing you can do using git that allows you to edit it on the computer and then run a command that puts it up on GitHub, but I don’t know how to set that up, so you’ll have to figure it out yourself.

A side note, I’ve just set up a branch for a part of the pirate thing I’ve been working on. My idea is you work on the piratemission branch and I’ll work on the thegiraffe3work branch, and then we can compare them later.

ProNooberEX commented 2 weeks ago

Ok, I'll try to figure it out. Btw if there are any questions on coding, can I ask for your advice?

TheGiraffe3 commented 2 weeks ago

You can ask. I’m not sure I’ll be able to give good advice though, because I’m not a good programmer 😉

TheGiraffe3 commented 2 weeks ago

@ProNooberEX can you start a PR to your master branch from the piratemission branch? Just so we can see all your changes in one place? I’ve got a PR from my branch started, so it’s easy to see my changes.

ProNooberEX commented 2 weeks ago

Ok I'll try Btw how do I start a PR?

TheGiraffe3 commented 2 weeks ago

You go to Pull Requests, and then click New. Set the base to master and the compare to piratemission. You’ll want to make sure that it’s your master and not the main game master for now.

ProNooberEX commented 2 weeks ago

I can only see the "New Pull Request" Button

TheGiraffe3 commented 2 weeks ago

It does the same thing. I probably have a smaller screen, and that’s why the Pull Request part doesn’t show up for me. New Pull Request will work.

ProNooberEX commented 2 weeks ago
截屏2024-06-12 18 29 24
ProNooberEX commented 2 weeks ago

Like this?

TheGiraffe3 commented 2 weeks ago

It looks like you did it to the wrong repository (the main game repository instead of the one here).

TheGiraffe3 commented 2 weeks ago

You might want to close that one or mark it as a draft, because the missions definitely aren’t ready yet.

ProNooberEX commented 2 weeks ago

截屏2024-06-12 18 42 39 Which ones should I edit?

TheGiraffe3 commented 2 weeks ago

It should look something IMG_2514 like this.

TheGiraffe3 commented 2 weeks ago

Then it will change to this. IMG_2515

ProNooberEX commented 2 weeks ago
截屏2024-06-12 18 53 15

Like this then create pull request?

TheGiraffe3 commented 2 weeks ago

Yes.

ProNooberEX commented 2 weeks ago

Added it

TheGiraffe3 commented 2 weeks ago

I’ve now marked yours as a draft and added the labels to it.

ProNooberEX commented 2 weeks ago

Thanks! Although I wonder at what the pull request are for.

TheGiraffe3 commented 2 weeks ago

Thanks! Although I wonder at what the pull request are for.

You may want to create a private repository and just mess around with it for a few minutes. It can be really helpful for learning how to use GitHub. Pul requests are for if you have something you want to be somewhere else but can’t write to the other place. Normally a Pull Request (PR) should be in a mostly done state.

ProNooberEX commented 2 weeks ago

Btw if you wish to replace the pirates building a wormhole idea, have you got any suggestions to legitimize the Southern pirates ability to raid the northern ones?

TheGiraffe3 commented 2 weeks ago

Could they get Jump Drives?

ProNooberEX commented 2 weeks ago

Could they get Jump Drives?

They could but that wont make the quargs mad enough to launch an operation...

TheGiraffe3 commented 2 weeks ago

I was thinking if they had them they could go through the Ember Waste, Korath space, then to Misam and go through the uninhabited systems between there and Arneb.

ProNooberEX commented 2 weeks ago

I was thinking if they had them they could go through the Ember Waste, Korath space, then to Misam and go through the uninhabited systems between there and Arneb.

From the perspective of the pirates that would mean all of the raiding ships equppied with jump drives and enough defense and power to overcome Korath ships, if that is the case then I think the pirates would have taken over the entire galaxy along time ago.

TheGiraffe3 commented 2 weeks ago

Well, they would be unlikely to jump in near the Korath.

TheGiraffe3 commented 2 weeks ago

If not, I don’t know. We could add a string of systems up the west side of space, but that doesn’t really work well…

ProNooberEX commented 2 weeks ago

If not, I don’t know. We could add a string of systems up the west side of space, but that doesn’t really work well…

Maybe cloaking devices and ramscoops helping the pirate ships sail across the entire Republic space?

TheGiraffe3 commented 2 weeks ago

If they had JD and Quantum Keystones they could go through the wormhole to the Gegno, and then East through Bunrodea space.

TheGiraffe3 commented 2 weeks ago

But the chances of them having JD are slim…

TheGiraffe3 commented 2 weeks ago

If not, I don’t know. We could add a string of systems up the west side of space, but that doesn’t really work well…

Maybe cloaking devices and ramscoops helping the pirate ships sail across the entire Republic space?

I’m not sure cloaking devices works, there are only four in the game right now. But ramscoops, and in the main game repository Azure3141 has a bunch of Pull Requests adding uninhabited systems all over human space that the pirates could go through.

ProNooberEX commented 2 weeks ago

But the chances of them having JD are slim…

Or we could only add one unstable wormhole near the men systems and another in the northern pirate space, this case the pirates only need quantum keystones, which are easy to collect and feasible considering the pirates' powers

TheGiraffe3 commented 2 weeks ago

Numbers 9867, 9755, and 9754.

TheGiraffe3 commented 2 weeks ago

But the chances of them having JD are slim…

Or we could only add one unstable wormhole near the men systems and another in the northern pirate space, this case the pirates only need quantum keystones, which are easy to collect and feasible considering the pirates' powers

That would work. Maybe Fumalsamakah? And then Hatysa.

ProNooberEX commented 2 weeks ago

But the chances of them having JD are slim…

Or we could only add one unstable wormhole near the men systems and another in the northern pirate space, this case the pirates only need quantum keystones, which are easy to collect and feasible considering the pirates' powers

That would work. Maybe Fumalsamakah? And then Hatysa.

Yeah, or new systems could also do the trick

ProNooberEX commented 2 weeks ago

But the chances of them having JD are slim…

Or we could only add one unstable wormhole near the men systems and another in the northern pirate space, this case the pirates only need quantum keystones, which are easy to collect and feasible considering the pirates' powers

That would work. Maybe Fumalsamakah? And then Hatysa.

Yeah, or new systems could also do the trick

But again the problem is that the quargs wouldn't be mad in this case as the unstable wormholes already pre-exists.

TheGiraffe3 commented 2 weeks ago

Well, the Quarg don’t like people attacking merchants—I tried once in Enif and was immediately destroyed. Then you could have it as some pirates hanged up and managed to take down and loot a Wardragon. That would get them in big trouble.

ProNooberEX commented 2 weeks ago

Well, the Quarg don’t like people attacking merchants—I tried once in Enif and was immediately destroyed. Then you could have it as some pirates hanged up and managed to take down and loot a Wardragon. That would get them in big trouble.

Do quarg ships enter the northern spaces that often? As far as my play experiences goes there hadn't been instances where quargs would be showing up there.

TheGiraffe3 commented 2 weeks ago

Good point. But they could have robbed the Quarg in the south and then gone north. Also, Hai space has Quarg who the northern pirates could attack-maybe.

ProNooberEX commented 2 weeks ago

Good point. But they could have robbed the Quarg in the south and then gone north. Also, Hai space has Quarg who the northern pirates could attack-maybe.

Indeed, we could say that as the quargs and the northern pirates had rarely ever contacted, once they met the pirates would think its just a strange exotic looking vessel with powerfull weapons they crave and board it, causing the hostility of the quarg(similiar to what I did in the game on a previous file).