Profpatsch / yarn2nix

Build and deploy node packages with nix from yarn.lock files.
MIT License
85 stars 21 forks source link

fix(yarn2nix): on --template generate key set instead of name attr #29

Closed sternenseemann closed 4 years ago

sternenseemann commented 4 years ago

Since d607336935c8131872ee97a7f12aa7a0965f63f6 buildNodePackage doesn't accept a name argument anymore, but a key one. Due to an oversight in that change yarn2nix --template would still generate name attributes which causes buildNodePackage to fail if directly used with callTemplate and an automatically generated template.

The issue is also described in #25 and should be resolved by this PR (except for the parentheses in README).

Profpatsch commented 4 years ago

thx!