Closed danielmrey closed 6 years ago
SimonPadbury
commented
6 years ago I have allowed this, not I don't understand why you want the sidebar headers to be h2. How is that not bad for SEO, when surely the sidebars are less important than the article itself?
danielmrey
commented
6 years ago We spoke about this long time ago.
1 > There has to be one H1 per page 2 > Then in order and with no gaps from H1, H2, H3, H4, H5 and H6 3 > Headers are nested, so H2 belongs to H1, H3 belongs to H2 and then to H1, etc...
If you put H4 in sidebar you break 2 rules
A > Unless you put H2 and H3 in the body you break rule 2 B > And even if rule A is achieved maybe Sidebar information does not belog to that thread H1 > H2 > H3 > H4 Sidebar that breaks rules 3
Having H2 in sidebar opens a new piece of information or Article independent of other parts... We can style this differently to the H2 in Main:
.main-contents h2 {rule;} .sidebar-contents h2 {rule;}
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 06:50, Simon Padbury notifications@github.com wrote:
I have allowed this, not I don't understand why you want the sidebar headers to be h2. How is that not bad for SEO, when surely the sidebars are less important than the article itself?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/pull/13#issuecomment-364840179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcRE_3VjVVGbqHFtL4coebuQxfukUI4ks5tT98tgaJpZM4SBcd1 .
SimonPadbury
commented
6 years ago Like I said, I allowed it but I am not convinced. The sidebar and footer headers look too massive.
On 12 Feb 2018, at 11:19, danielmrey notifications@github.com wrote:
We spoke about this long time ago.
1 > There has to be one H1 per page 2 > Then in order and with no gaps from H1, H2, H3, H4, H5 and H6 3 > Headers are nested, so H2 belongs to H1, H3 belongs to H2 and then to H1, etc...
If you put H4 in sidebar you break 2 rules
A > Unless you put H2 and H3 in the body you break rule 2 B > And even if rule A is achieved maybe Sidebar information does not belog to that thread H1 > H2 > H3 > H4 Sidebar that breaks rules 3
Having H2 in sidebar opens a new piece of information or Article independent of other parts... We can style this differently to the H2 in Main:
.main-contents h2 {rule;} .sidebar-contents h2 {rule;}
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 06:50, Simon Padbury notifications@github.com wrote:
I have allowed this, not I don't understand why you want the sidebar headers to be h2. How is that not bad for SEO, when surely the sidebars are less important than the article itself?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/pull/13#issuecomment-364840179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcRE_3VjVVGbqHFtL4coebuQxfukUI4ks5tT98tgaJpZM4SBcd1 .
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/pull/13#issuecomment-364894311, or mute the thread https://github.com/notifications/unsubscribe-auth/AFTFpZZxPWxApY3idH6tPF63zNaYvi65ks5tUB40gaJpZM4SBcd1.
danielmrey
commented
6 years ago The important thing is that they are correct for SEO
If the fonts are massive just adjust the styling very easily:
.sidebar h2 {rule;} .footer h2 {rule;}
But Simon if you are not convinced then don't do it... I would do it then in my child...
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 13:49, Simon Padbury notifications@github.com wrote:
Like I said, I allowed it but I am not convinced. The sidebar and footer headers look too massive.
On 12 Feb 2018, at 11:19, danielmrey notifications@github.com wrote:
We spoke about this long time ago.
1 > There has to be one H1 per page 2 > Then in order and with no gaps from H1, H2, H3, H4, H5 and H6 3 > Headers are nested, so H2 belongs to H1, H3 belongs to H2 and then to H1, etc...
If you put H4 in sidebar you break 2 rules
A > Unless you put H2 and H3 in the body you break rule 2 B > And even if rule A is achieved maybe Sidebar information does not belog to that thread H1 > H2 > H3 > H4 Sidebar that breaks rules 3
Having H2 in sidebar opens a new piece of information or Article independent of other parts... We can style this differently to the H2 in Main:
.main-contents h2 {rule;} .sidebar-contents h2 {rule;}
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 <+44%207765%20170430> www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 06:50, Simon Padbury notifications@github.com wrote:
I have allowed this, not I don't understand why you want the sidebar headers to be h2. How is that not bad for SEO, when surely the sidebars are less important than the article itself?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/ pull/13#issuecomment-364840179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcRE_ 3VjVVGbqHFtL4coebuQxfukUI4ks5tT98tgaJpZM4SBcd1 .
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ Progenitor-Theme/progenitor/pull/13#issuecomment-364894311, or mute the thread https://github.com/notifications/unsubscribe-auth/ AFTFpZZxPWxApY3idH6tPF63zNaYvi65ks5tUB40gaJpZM4SBcd1.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/pull/13#issuecomment-364927345, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcREwQsvQJ6fefjMv1bQq0DkK_0-gYIks5tUEFRgaJpZM4SBcd1 .
SimonPadbury
commented
6 years ago No, as I said, I have allowed it, bowing to you r better judgment.
It just looks silly.
On 12 Feb 2018, at 13:57, danielmrey notifications@github.com wrote:
The important thing is that they are correct for SEO
If the fonts are massive just adjust the styling very easily:
.sidebar h2 {rule;} .footer h2 {rule;}
But Simon if you are not convinced then don't do it... I would do it then in my child...
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 13:49, Simon Padbury notifications@github.com wrote:
Like I said, I allowed it but I am not convinced. The sidebar and footer headers look too massive.
On 12 Feb 2018, at 11:19, danielmrey notifications@github.com wrote:
We spoke about this long time ago.
1 > There has to be one H1 per page 2 > Then in order and with no gaps from H1, H2, H3, H4, H5 and H6 3 > Headers are nested, so H2 belongs to H1, H3 belongs to H2 and then to H1, etc...
If you put H4 in sidebar you break 2 rules
A > Unless you put H2 and H3 in the body you break rule 2 B > And even if rule A is achieved maybe Sidebar information does not belog to that thread H1 > H2 > H3 > H4 Sidebar that breaks rules 3
Having H2 in sidebar opens a new piece of information or Article independent of other parts... We can style this differently to the H2 in Main:
.main-contents h2 {rule;} .sidebar-contents h2 {rule;}
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 <+44%207765%20170430> www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 06:50, Simon Padbury notifications@github.com wrote:
I have allowed this, not I don't understand why you want the sidebar headers to be h2. How is that not bad for SEO, when surely the sidebars are less important than the article itself?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/ pull/13#issuecomment-364840179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcRE_ 3VjVVGbqHFtL4coebuQxfukUI4ks5tT98tgaJpZM4SBcd1 .
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ Progenitor-Theme/progenitor/pull/13#issuecomment-364894311, or mute the thread https://github.com/notifications/unsubscribe-auth/ AFTFpZZxPWxApY3idH6tPF63zNaYvi65ks5tUB40gaJpZM4SBcd1.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/pull/13#issuecomment-364927345, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcREwQsvQJ6fefjMv1bQq0DkK_0-gYIks5tUEFRgaJpZM4SBcd1 .
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/pull/13#issuecomment-364929596, or mute the thread https://github.com/notifications/unsubscribe-auth/AFTFpd4_k3WYe2_R1ejybTROl39lUmsOks5tUEMygaJpZM4SBcd1.
danielmrey
commented
6 years ago Thank you for trusting mu judjement but If it just looks silly change the CSS rules:
.sidebar h2 {rule;} .footer h2 {rule;}
And if you are not happy then revert it... This is your project and you must be happy with it!
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 14:01, Simon Padbury notifications@github.com wrote:
No, as I said, I have allowed it, bowing to you r better judgment.
It just looks silly.
On 12 Feb 2018, at 13:57, danielmrey notifications@github.com wrote:
The important thing is that they are correct for SEO
If the fonts are massive just adjust the styling very easily:
.sidebar h2 {rule;} .footer h2 {rule;}
But Simon if you are not convinced then don't do it... I would do it then in my child...
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 <+44%207765%20170430> www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 13:49, Simon Padbury notifications@github.com wrote:
Like I said, I allowed it but I am not convinced. The sidebar and footer headers look too massive.
On 12 Feb 2018, at 11:19, danielmrey notifications@github.com wrote:
We spoke about this long time ago.
1 > There has to be one H1 per page 2 > Then in order and with no gaps from H1, H2, H3, H4, H5 and H6 3 > Headers are nested, so H2 belongs to H1, H3 belongs to H2 and then to H1, etc...
If you put H4 in sidebar you break 2 rules
A > Unless you put H2 and H3 in the body you break rule 2 B > And even if rule A is achieved maybe Sidebar information does not belog to that thread H1 > H2 > H3 > H4 Sidebar that breaks rules 3
Having H2 in sidebar opens a new piece of information or Article independent of other parts... We can style this differently to the H2 in Main:
.main-contents h2 {rule;} .sidebar-contents h2 {rule;}
Thank you.
Best Regards.
Daniel Muñoz Rey Web Developer +44 (0)776 517 0430 <+44%207765%20170430> <+44%207765%20170430> www.danielmrey.com info@danielmrey.com
The information transmitted is intended only for the recipient to which it is addressed, any use by others is prohibited. If you received this in error, please contact the sender on info@danielmrey.com and delete the material from any computer. Thank you.
On 12 February 2018 at 06:50, Simon Padbury < notifications@github.com> wrote:
I have allowed this, not I don't understand why you want the sidebar headers to be h2. How is that not bad for SEO, when surely the sidebars are less important than the article itself?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/ pull/13#issuecomment-364840179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcRE_ 3VjVVGbqHFtL4coebuQxfukUI4ks5tT98tgaJpZM4SBcd1 .
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ Progenitor-Theme/progenitor/pull/13#issuecomment-364894311, or mute the thread https://github.com/notifications/unsubscribe-auth/ AFTFpZZxPWxApY3idH6tPF63zNaYvi65ks5tUB40gaJpZM4SBcd1.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/ pull/13#issuecomment-364927345, or mute the thread https://github.com/notifications/unsubscribe-auth/ AAcREwQsvQJ6fefjMv1bQq0DkK_0-gYIks5tUEFRgaJpZM4SBcd1 .
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ Progenitor-Theme/progenitor/pull/13#issuecomment-364929596, or mute the thread https://github.com/notifications/unsubscribe-auth/AFTFpd4_k3WYe2_ R1ejybTROl39lUmsOks5tUEMygaJpZM4SBcd1.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Progenitor-Theme/progenitor/pull/13#issuecomment-364930566, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcRE_qH7BRckNjBcuz_SaA6IaBO_vNrks5tUEQdgaJpZM4SBcd1 .
I think is better if sidebar headers are H2