Fancybox Gallery - Githubissues

danielmrey commented 6 years ago

Hi Simon:

I just implemented Fancybox Gallery functionality to Wordpress native galleries and it works beautifully.

I followed the same way you did for bootstrap-4 and font-awesome-5.

I didn't use any number for version, I think is best not to put version in folders so is more transportable in future
Can you please give it a look and let me know if I did it all right?
I needed to add a piece of code to read the alt tag of the image and place it as caption for the pop up image, this code is in fancybox/fancybox.php, is it ok here or should it go in any other file?
For web performance speed I'd like to add all the files for Fancybox (1CSS and 2 JS) only when we have a Wordpress gallery, you suggested: if (strpos($post->post_content,'[gallery') === true) { // load your stuff } but I think this will take a lot of PHP resources as it has to read every time it loads a page and in a page then reads all contents to decide if there is a gallery there, do you know any other way?

Thank you!

SimonPadbury commented 6 years ago

OK, then also remove the -4 and the-5 from bootstrap and font-awesome.

I may have time to look later this week.

danielmrey commented 6 years ago

I prefer you do to these 2 changes -4 and -5 if you don't mind

Progenitor-Theme / progenitor