LogA: Make trikita.log invisible to ARTistGUI

Project-ARTist / dexterous

Library and standalone CLI tool for apk/dex merging, repackaging and signing. Can also get used as a dex analyzer framework.

Other

48 stars 16 forks source link

LogA: Make trikita.log invisible to ARTistGUI #6

Open partipan-dot opened 6 years ago

partipan-dot commented 6 years ago

The logging methods in LogA respect the set log level and ARTistGuishould depend only on LogA. It shouldn't be able to call trikita.log directly.

This change depends on: Project-ARTist/ArtistGui#62

schrnz commented 6 years ago

I am fine with this, seems like a good idea to enforce the usage of the LogA API. In terms of ordering: I assume that we can accept this PR without breaking anything, then reference this in ArtistGui's dexterous submodule, update https://github.com/Project-ARTist/ArtistGui/pull/62 correspondingly and then accept that PR as well?

partipan-dot commented 6 years ago

No, this change breaks ARTistGUI directly after merging this PR. ARTistGUI calls logging methods from trikita.log in several places. Project-ARTist/ArtistGui#62 replaces all calls to methods from trikita.log and android.util.log. After merging this PR the CI PR test for Project-ARTist/ArtistGui#62 will pass. It can't find the submodule commit hash (in this PR) currently.