Fix IgniteInfo can not import issue

Project-MONAI / MONAI

AI Toolkit for Healthcare Imaging

https://monai.io/

Apache License 2.0

5.93k stars 1.09k forks source link

Fix IgniteInfo can not import issue #8121

Closed KumoLiu closed 2 months ago

KumoLiu commented 2 months ago

Fixes #8120 .

Types of changes

[x] Non-breaking change (fix or new feature that would not break existing functionality).
[ ] Breaking change (fix or new feature that would cause existing functionality to change).
[ ] New tests added to cover the changes.
[ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
[ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
[ ] In-line docstrings updated.
[ ] Documentation updated, tested make html command in the docs/ folder.

KumoLiu commented 2 months ago

/build

KumoLiu commented 2 months ago

/build

mingxin-zheng commented 2 months ago

Hi @KumoLiu , do you think we'll need to change this line too?

https://github.com/Project-MONAI/MONAI/blob/8546be098daaf6841c39a2748412bbda83929c92/monai/utils/enums.py#L730

The version of Ignite in requirements-dev.txt is 0.4.11

KumoLiu commented 2 months ago

/build

KumoLiu commented 2 months ago

/build

mingxin-zheng commented 2 months ago

By the way, do you think a deprecated class should also be included in the __all__ definitions?

https://github.com/Project-MONAI/MONAI/blob/754ca155a72e2e448c776d13930f69fce75da909/monai/config/deviceconfig.py#L41

I don't have a strong opinion on this. Either way makes sense.

KumoLiu commented 2 months ago

By the way, do you think a deprecated class should also be included in the __all__ definitions?

https://github.com/Project-MONAI/MONAI/blob/754ca155a72e2e448c776d13930f69fce75da909/monai/config/deviceconfig.py#L41

Yes, added.

KumoLiu commented 2 months ago

/build