Project-MONAI / research-contributions

Implementations of recent research prototypes/demonstrations using MONAI.
https://monai.io/
Apache License 2.0
1.02k stars 336 forks source link

segresnet mlflow support #330

Closed myron closed 1 year ago

myron commented 1 year ago

segresnet mlflow support

Nic-Ma commented 1 year ago

Hi @dongyang0122 , @drbeh ,

Could you please help review this PR? Ensure it can satisfy our requirements for the MLFlow URI.

Thanks in advance.

dongyang0122 commented 1 year ago

Please update the PR as follows. Thanks!

  1. In algo.py, add these two lines.
  2. Create a new key in hyperparameter.yaml.
  3. Pass mlflow_tracking_uri into train.py.

Thanks.

drbeh commented 1 year ago

@myron I would appreciate it if you can address the comment as soon as you can so we can use mlflow for segresnet in monai services. Thanks

myron commented 1 year ago

I've updated, please check

myron commented 1 year ago

The changes look good to me. Can you also update this file? Thanks. https://github.com/myron/research-contributions/blob/updates/auto3dseg/metadata.json

Done.

dongyang0122 commented 1 year ago

The changes look good to me. Can you also update this file? Thanks. https://github.com/myron/research-contributions/blob/updates/auto3dseg/metadata.json

Done.

Thanks.