Open wyli opened 3 years ago
this is from our nightly CI tests, could you please help look into the testing error @ahatamiz? I think you can replicate it with this command:
./runner.sh -p "-and \( -name '*unetr*' \)"
this is from our nightly CI tests, could you please help look into the testing error @ahatamiz? I think you can replicate it with this command:
./runner.sh -p "-and \( -name '*unetr*' \)"
Thanks @wyli. The testing error is due to the fact that dataset_0.json
is not placed in the /dataset/
folder. As we explained in the Download dataset and format in the folder cell, the user needs to download dataset and put json file on that folder. Since the dataset requires additional registration step, we cannot link to it and download it.
One change I can think of is to host the json file on the cloud, download it and place it in the right folder. But user still needs to download the dataset itself.
sure, we have a share drive for demo/testing data (https://drive.google.com/drive/u/2/folders/1ZOqwF44newvq-jOSgnbXRDWRD9DRq8hH), is it possible to put a subset there?
otherwise I can think of two approaches:
Try...Except
the runtime error in the notebook, so that it stops quietly if there is no dataI'm fine with all these approaches... cc @rijobro @ericspod @Nic-Ma comments?
Hi @wyli I checked again and unfortunately it is not possible to publicly release portions of dataset ( needs user registration on their website). I can certainly create a new PR that reflects your solutions, if this is what we agree on.
Thanks
Hi @wyli I checked again and unfortunately it is not possible to publicly release portions of dataset ( needs user registration on their website). I can certainly create a new PR that reflects your solutions, if this is what we agree on.
Thanks
Sounds good, we deploy the tests mainly to detect basic errors due to API changes, we also manually check these notebooks before major releases. So some gentle tests or skip the tests are ok...
i'm submitting a PR (#292) to skip the test for unetr.
Describe the bug log: https://github.com/Project-MONAI/MONAI/runs/3073470810?check_suite_focus=true