[Bug]: Selected asset respons to keypresses Backspace/Delete unclear

Project-OMOTES / user_feedback

Repository to hold all feedback (bugs and feature request) from users

1 stars 0 forks source link

[Bug]: Selected asset respons to keypresses Backspace/Delete unclear #24

Open JurrianVRHDHV opened 5 months ago

JurrianVRHDHV commented 5 months ago

Is there an existing issue for this?

[X] I have searched the existing issues.

What happened?

A selected (highlighted) asset indicates response to the backspace & delete keys when pressed, but causes no action.

Steps to reproduce the problem

Open ESDL map editor
Create a polygon and assign an asset (tried multiple types, same response).
Select the asset circle (which should highlights with a white ring).
Press random keys gives no indication of respons
Pres Delete/Backspace creates a black ring within the highlighted white ring. (Unable to produce an image, as issue only persist whilst pressing the delete/backspace buttons (So ask me, if unclear))
No other changes to the asset attributes

What should have happened?

Action unknown. A highlight after pressing a key indicates an action, but no action/change to the asset or attributes has been found.

What browsers do you use to access the UI?

Microsoft Edge

Additional information

No response

edwinmatthijssen commented 5 months ago

Thanks for reporting this using a very detailed description! I will look into it next week. The only thing that’s still a bit unclear is step 2 and then mainly the verbs “CREATE a polygon and ASSIGN an asset”. Do you draw an asset using the polygon draw tool? Or do you draw an Area polygon and draw an asset (point) in this Area?

JurrianVRHDHV commented 5 months ago

I'll try to use the correct terminology next times. I tried :

Draw a polygon use the polygon draw tool then draw an asset (generic consumer, heat storage, gasheater) in the area
Draw a rectangle tool then draw an asset (generic consumer, heat storage, gasheater) in the area
Select asset (generic consumer, heat storage, gasheater) then draw an area, using the polygon/rectangle drawing tool
Select asset (generic consumer, heat storage, gasheater) then place the asset (pont) directly. All resulting the in same situation.

edwinmat commented 5 months ago

I'm able to reproduce this behavior, but the black ring only appears when the sidebar with asset properties is open. Is this the case at your side too? I'll try to find out what causes the black ring to appear...

JurrianVRHDHV commented 5 months ago

Similair to you. In my case, the behaviour only appears with the sidebar with asset properties is open and the asset is still selected.

It does not happen if the asset has been deselected, but with the asset sidebar still open.
It does not happen if the asset is still highlighted, but the asset sidebar has been closed. (after first selecting the asset and opening the asset sidebar).

edwinmatthijssen commented 5 months ago

I shortly discussed it with @ewoudwerkman and the black ring behavior is not part of our own code, but (probably) from one of the external libraries we use. I'm not sure why it's there and it's definitely not easy to remove. The question is, how big of a problem this is for you?

JurrianVRHDHV commented 5 months ago

A very minor issue. I came across the response and it confused me. In many programs pressing delete or backspace can be used to remove an object/asset/information/content. The response of the keypress gave me the impression that something was deleted, but after checking I realised nothing had changed and it does not affect me anymore. I can see the potential confusion for others, but it would be very minor for the majority of users.

edwinmatthijssen commented 5 months ago

If I remember right, pressing 'd' deletes something (which is also confusing maybe)... There are multiple other keys that have a special meaning, like 'p' for drawing a pipe and 'c' for drawing a cable. Some of them are documented in the online documentation, but I don't find the documentation for 'd'. It's all work in progress... :(

edwinmatthijssen commented 5 months ago

By the way... I don't think pressing delete when the sidebar is open (for editing the asset properties) should delete the asset. That would also not be logical to me.

JurrianVRHDHV commented 5 months ago

A hotkey shortlist would be a nice addition for the far future. (that could be part of optional UI customization), but not needed for the functionality of the toolkit. Having hotkeys that nobody knows exist are not that usefull, but they dont make the tool less usable.

And I agree that pressing the delete key should not remove the asset (that would be too risky). At most it should deselect the asset or give a prompt to ask you if you want to delete the asset.