5.4.0 - Githubissues

Project-OSRM / node-osrm

DEPRECATED Part of osrm-backend since 5.7. NodeJS bindings for OSRM

BSD 2-Clause "Simplified" License

141 stars 48 forks source link

5.4.0 #252

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

New PR, rebased against latest master, targeting the 5.4.0 release.

Downgrades to lua 5.2 to reduce memory usage and increase performance compared to lua 5.3
Includes updated mason binaries for lua 5.2 that were built with -O3 for best speed
Targeting osrm-backend@v5.4.0

@MoKob @freenerd - feel free to use this branch for further 5.4.0 release candidates, or merge this into your existing 5.4 branch. Either way I think we should pull in latest master, which this does. But I did not want to do that directly into 5.4 before testing that travis passed and before syncing with you tomorrow.

codecov-io commented 8 years ago

Current coverage is 95.00% (diff: 100%)

Merging #252 into master will not change coverage

@@             master       #252   diff @@
==========================================
  Files             4          4          
  Lines           420        420          
  Methods          40         40          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            399        399          
  Misses           21         21          
  Partials          0          0

Powered by Codecov. Last update 1f07ddb...ddc59a0

MoKob commented 8 years ago

@springmeyer what parts of this do we need to still put into master? Seems it has some 5.4 stuff in it. Can you check what remains here?

springmeyer commented 8 years ago

@MoKob this can be closed. It was 5.4 rebased against master (so with the lastest improvements from master and therefore was intended to merged into 5.4. It looks like that already happened as I see the right commits from master now in the 5.4 branch. So nothing to do here.