search

Project60 / org.project60.sepa

SEPA direct debit integration with civicrm
19 stars 46 forks source link

Fix for #697: Compatibility with CiviCRM 5.69 #698

Closed jaapjansma closed 5 months ago

jaapjansma commented 8 months ago

This fixes the issue with CiviCRM 5.69.

This PR is tested on CiviCRM 5.69 and 5.14 (so it is still backwards compatible)l

See #697

jaapjansma commented 8 months ago

@bjendres are you able to review this PR and merge it if ok?

jensschuppe commented 6 months ago

I think this should do a complete civix upgrade@23.02.1 which leaves _sepa_civix_civicrm_config() with no template-specific code altogether …

jaapjansma commented 6 months ago

Yes that might be good. However I have a little objection against that it might break the working of this extension on older versions of CiviCRM when we do that.

bjendres commented 6 months ago

@bjendres are you able to review this PR and merge it if ok?

I can't really assess the consequences of these changes, but it looks reasonable to me. If the two of you think it makes sense, I'll merge and release with 1.10.

jensschuppe commented 6 months ago

I didn't test this PR, but I guess it'll work for that specific scenario and merging for an intermediate version makes sense.

A full civix upgrade however seems necessary for Smarty 3 support (I saw errors without it on CiviCRM 5.71), so maybe let's do that as a follow-up. Current Civix code for the extension is backwards-compatible with CiviCRM 5.45 because of the entity-types mixin:

! [NOTE] The requirements should be increased because "entity-types-php@1.0.0" requires CiviCRM 5.45.

PS. See #704 for the follow-up.

bjendres commented 5 months ago

Thanks @jaapjansma