search

ProjectMOSAIC / mosaic

Project MOSAIC R package
http://mosaic-web.org/
93 stars 26 forks source link

deprecate plotModel()? #701

Open rpruim opened 6 years ago

rpruim commented 6 years ago

Given developments in ggformula and mosaicModel and the fact that we never really reached a desired end state for plotModel(), I'm wondering if we should deprecate plotModel() with an eye toward eventual elimination.

@dtkaplan, any thoughts?

dtkaplan commented 6 years ago

Just as a matter of naming conventions, I think we should settle on mod_plot, as in the mosaicModel package, and deprecate others. That doesn't prevent us from moving features from plotModel() to mod_plot(), but it does provide a single gateway to the functionality for plotting models.

On Fri, Mar 30, 2018 at 10:21 AM Randall Pruim notifications@github.com wrote:

Given developments in ggformula and mosaicModel and the fact that we never really reached a desired end state for plotModel(), I'm wondering if we should deprecate plotModel() with an eye toward eventual elimination.

@dtkaplan https://github.com/dtkaplan, any thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ProjectMOSAIC/mosaic/issues/701, or mute the thread https://github.com/notifications/unsubscribe-auth/AAggrTkAsy44KeXJQPaGn4xvkuYTZN_Hks5tjk1xgaJpZM4TBznK .

nicholasjhorton commented 6 years ago

I'm a fan of plotModel(), even in its incomplete state. It shows up in a number of our resources (including minimal R, no?). I'm okay with deprecation if there are good examples of how the same functionality can be achieved.

rpruim commented 6 years ago

I'll have to do some looking to see the current state of model plotting in mosaicModel and whether any important things would be lost if we remove plotModel(). If we do end up keeping this (or something like it), we should probably move it into mosaicModel(). We can always re-export it from mosaic for backward compatibility. But it seems like it belongs with the other things in mosaicModel. (And whatever things we keep need a vignette or better documentation.)

rpruim commented 6 years ago

For now, I think I'll just leave this as is.

nicholasjhorton commented 6 years ago

I'd welcome a chance to talk more about plotModel() and the mosaicModel package. I agree that we need a vignette and better documentation.

rpruim commented 6 years ago

Take a look at the vignette in mosaicModel and see what you think. I'm working on improvements so that mod_plot() can be layered after other layers in ggformula(). Likely it will get an alias like gf_model() as well so that people working primarily in either mosaicModel or ggformula will have a name that looks right to them.

nicholasjhorton commented 6 years ago

Is this the vignette from 9 months ago?

Nick

On Jun 12, 2018, at 8:57 PM, Randall Pruim notifications@github.com wrote:

Take a look at the vignette in mosaicModel and see what you think. I'm working on improvements so that mod_plot() can be layered after other layers in ggformula(). Likely it will get an alias like gf_model() as well so that people working primarily in either mosaicModel or ggformula will have a name that looks right to them.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Nicholas Horton Professor of Statistics Department of Mathematics and Statistics, Amherst College PO Box 5000, AC #2239 Amherst, MA 01002-5000

nicholasjhorton commented 6 years ago

I'd like to propose a slow deprecation on this front (15 months?) since it's still not clear to me what functionality we want to use in the materials that are being updated for the 2018-2019 academic year. Can we find a time to talk?