search

ProjectPythia / pythia-foundations

Jupyterbook source for the Foundations collection
http://foundations.projectpythia.org
Apache License 2.0
60 stars 43 forks source link

Protected branch for main? #119

Open dopplershift opened 3 years ago

dopplershift commented 3 years ago

Do we want to make main a protected branch? This means that force-pushing to and deleting the branch is disallowed for everyone (unless we specifically allow it). We also have these options available to us:

The last one is one I'm interested in, not as a gate-keeping exercise, but it allows us to use "auto-merge". With that we can mark a PR to merge as soon as all of the required checks pass.

brian-rose commented 3 years ago

+1 for auto-merging, especially for bot-generated maintenance PRs.

I think we're probably ready to implement the "require a review from a codeowner" rule now that we have a sensible team-based codeowner system in place, so that it's very unlikely we'll be stuck waiting on any one individual who might be away/unavailable to review.

dcamron commented 2 years ago

EWG today on board with protecting main. Discussions can still be had here about specific PR status/review requirements, but the starting point seemed to be "what's in place in our other repos".