Increase number of labels displayed

ProjectSidewalk / SidewalkGallery

A gallery for Project Sidewalk

MIT License

1 stars 0 forks source link

Increase number of labels displayed #26

Open aileenzeng opened 4 years ago

aileenzeng commented 4 years ago

Currently hardcoding a small number of labels to be displayed. This is definitely not ideal, but there are a couple considerations that we need to take into account before increasing the count.

[ ] Filter for labels with expired panoIds. (We don't filter these out at the moment). This should happen on the backend before we actually send a response so the client doesn't need to worry about anything. (NOTE: this is irrelevant if we serve our own crops).
[ ] Add pagination (this minimizes the number of queries we need to make).

misaugstad commented 4 years ago

Filter for labels with expired panoIds. (We don't filter these out at the moment). This should happen on the backend

I believe there is an expired column in the gsv_panorama table that is at least somewhat up to date. You could start by filtering those out, but you would still probably want to check all the other ones before sending to the front-end. The expired column is only as up to date as the last time we tried to access the GSV API.