search

ProwlEngine / Prowl

An Open Source C# 3D Game Engine under MIT license, inspired by Unity and featuring a complete editor
MIT License
451 stars 38 forks source link

Chore: file scoped namespace #155

Closed brmassa closed 2 months ago

brmassa commented 2 months ago

Implementation of #154

Note: External projects (submodules DotCast and Veldrid) were not affected. It will raise warnings until they are changed in their own repos

michaelsakharov commented 2 months ago

Is merging into Main intended?

brmassa commented 2 months ago

Well why not?

AFAIK, development branch will basically overwrite main.

If eventually there is any file from main that will not be overwritten, we can perform this change on these dozen remaining files later.

Any thoughts?

PaperPrototype commented 2 months ago

As far as I know the plan was to do all development in the development branch and at points where it it is all cleaned up and ready we would do a single pull request into main. AKA every push to main functioning as a release? I believe this is what was decided last time it came up.

This keeps main stable and keeps all the volatility in the development branch. This way any pulls from main will "just work."

brmassa commented 2 months ago

@michaelsakharov ohhh now that Ive noticed that generate the Merge Request against main. My bad. It's designed to be applied to dev.