ProxymanApp / proxyman-windows-linux

Public tracker for Proxyman Windows/Linux
https://proxyman.io/
MIT License
92 stars 4 forks source link

Window Management button #4

Open NghiaTranUIT opened 2 years ago

NghiaTranUIT commented 2 years ago

Description

We should implement the logic for 3 window management buttons

Screen_Shot_2022-06-29_at_15_30_10

Acceptance Criteria

kics223w1 commented 1 year ago

After an evening of finding the solution for the last bug, I end up with nothing.

The bug is when SplitPane changes from vertical to horizontal or vice versa all rows in DataGrid will disappear. I have no idea why that happens. This issue Mui DataGrid rows disappear seems like a good solution but it still does not work. There is a not good solution is: We add rows again after changing the style SplitPane.

So please feel free to take over this ticket, you can use my code to reference. My code is done 90% if that bug is solved this ticket will be done. I will continue with ticket export.

Video Bug https://user-images.githubusercontent.com/77295189/184125585-529062e5-39d6-4041-85cc-7459f03f964c.mp4

NghiaTranUIT commented 1 year ago

The SplitPanel is super buggy IMO. It's not designed for ReactJS 18.

@kics223w1 let's try migrating to SplitJS: https://split.js.org/

Ref: https://github.com/ProxymanApp/proxyman-electron-app/pull/45

kics223w1 commented 1 year ago

Yes I got it.

NghiaTranUIT commented 1 year ago

Since we support the Source List Panel. We can revisit this ticket to make it works with all panels (Left, Middle, Right/Bottom).

Move this ticket to 0.10.0 version 👍