search

Purfview / IMDb-Scout-Mod

Auto search for movie/series on torrent, usenet, ddl, subtitles, streaming, predb and other sites. Adds links to IMDb pages from hundreds various sites. Adds movies/series to Radarr/Sonarr. Adds external ratings from Metacritic, Rotten Tomatoes, Letterboxd, Douban, Allocine. Media Server indicators for Plex, Jellyfin, Emby. Dark theme/style for Reference View. Adds/Removes to/from Trakt's watchlist. Removes ads
https://greasyfork.org/en/scripts/407284-imdb-scout-mod
MIT License
400 stars 50 forks source link

Add seeding status #238

Closed Audionut closed 4 days ago

Audionut commented 3 weeks ago

https://ptpimg.me/ydjdp5.png

Before I get too caried away with this, what say thee. Icon color is just standout, I'll defer to any suggestion.

Obviously not every site would be supported.

Purfview commented 3 weeks ago

Interesting idea.

Obviously not every site would be supported.

Why not? I guess you mean that for this to work you need positiveMatch? Maybe positiveMatch2 could be introduced?

Purfview commented 3 weeks ago

Notes: I wonder if it doesn't interfere with the icons sorting func. I guess someone wouldn't want this ON by default, IMO it's OK, not sure if it needs to be optional, maybe make a post in the private thread introducing this feature (with a link to the fork .js) to gather more input and tests on this.

Audionut commented 3 weeks ago

From experience with that sites script I maintain, not every site returns seeding status, either/or HTML or API.

The only thing I've done so far is see if I could actually make it work. I have done exactly zero testing save for that screenshot output. Although, I did have icons on one line first, and the seeded icon was first. Not sure if that was because of the order list, or because it's else if before else 'found'.

Presumably I could make it an option. I'm on mobile now, but presumably I could add an option check before the else if and assign icon as a seeding match.

Purfview commented 3 weeks ago

From experience with that sites script I maintain, not every site returns seeding status, either/or HTML or API.

That I understand, I thought that you meant that it returns status but it wouldn't be supported.

I did have icons on one line first, and the seeded icon was first..

That depends from order in const valid_states.

Presumably I could make it an option. I'm on mobile now, but presumably I could add an option check before the else if and assign icon as a seeding match.

Make a post there, if noone complains then no need for option, I think.

Audionut commented 3 weeks ago

Apart from waiting for that feedback, I don't think I can do much more with this. No other site I have access too has a seeding element available to hook onto.

If this gets pushed, would you like me to create an issue outlining how to find and add the regex match?

Purfview commented 3 weeks ago

If this gets pushed, would you like me to create an issue outlining how to find and add the regex match?

Eventually it will be, yeah you can create it at show and tell discussion, I'll link it in the PR "guide".

Purfview commented 3 weeks ago

I don't think I can do much more with this.

There is still one pending review.

Audionut commented 3 weeks ago

There is still one pending review.

I don't see a review anywhere.

Purfview commented 3 weeks ago

Don't you see it there after the second post?

Audionut commented 3 weeks ago

Nope. If you do actually mean a review comment on some line/s of code, it does have to be confirmed, I think top right hand corner, after making a comment at a line of code. It's a bit clunky how that works.

Purfview commented 3 weeks ago

Can you make a screenshot what is there for you?

Audionut commented 3 weeks ago

https://ptpimg.me/7lz2ru.png

Purfview commented 3 weeks ago

Did it appeared now?

Audionut commented 3 weeks ago

Eventually it will be, yeah you can create it at show and tell discussion, I'll link it in the PR "guide".

Added: https://github.com/Purfview/IMDb-Scout-Mod/discussions/240

I'll correct the link after merge so I can delete the branch.