Py0000 / pe

0 stars 0 forks source link

Unnecessary Case-Sensitive Command for add #2

Open Py0000 opened 2 years ago

Py0000 commented 2 years ago

User is required to type NA in uppercase when the user does not wish to input any contact number for a particular contact.

Perhaps there is not need for a strict rule for user to type NA in upper-case. A more relaxed rule, such as allowing na in lower-case will be better for fast typer.

image.png

nus-pe-bot commented 2 years ago

Team's Response

The p/ tag is entirely optional to begin with. Including the NA tag was just for congruence with what is displayed in the Academy Directory if the Avenger had itchy fingers and really needed to type in something for the EMPTY p/ field.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree with the team that the p/ tag is entirely optional, however considering the situation where the user has did try to use the p/ tag without any phone number, he would need to go through the trouble of typing the capitalized version of the 2 letters (NA). Thus, i believe that this situation is a rare scenario and will cause minor inconvenience to the user if they wanted to input p/ tag with no number. Since using na would work as well. Hence, this would be categorized as a low severity flaw.

Also, as stated in the module website, this could be considered a flaw.

image.png


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: As stated above, I believe that this situation is a rare scenario and will cause minor inconvenience to the user if they wanted to input p/ tag with no number. Since using na would work as well. Hence, this would be categorized as a low severity flaw. This flaw does not fall under the cosmetic category, hence i feel that it should not be of verylow severity.