search

Py0000 / pe

0 stars 0 forks source link

Better displayed message #4

Open Py0000 opened 2 years ago

Py0000 commented 2 years ago

Command tested: participation 1 ses/9 add/-100 to a student with participation marks 0 (as shown below)

The displayed message: Participation updated!

Perhaps, it would be better inform the user about the issue that the new participation is less than 0. (since the participation mark is not updated, remains as 0 as it cannot be below 0) This will also user to know immediately why the mark did not change, instead of thinking the participation is update as stated by the displayed message.

image.png

nus-pe-bot commented 2 years ago

Team's Response

Purely cosmetic as it does not actually impact the functionality nor does it misguide the user since even if you update from 0 to 0, it is still an update. ):

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]