search

PyCQA / bandit

Bandit is a tool designed to find common security issues in Python code.
https://bandit.readthedocs.io
Apache License 2.0
6.52k stars 612 forks source link

Add official Python 3.11 support #964

Closed ericwb closed 2 years ago

ericwb commented 2 years ago

Signed-off-by: Eric Brown eric_wade_brown@yahoo.com

bersbersbers commented 2 years ago

I feel stupid asking this, but why does this PR change these two lines?

https://github.com/PyCQA/bandit/pull/964/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R35

https://github.com/PyCQA/bandit/pull/964/files#diff-fac4c6890301d4de5c3f4266837803d5240c84a3d8b6c735bbc6a64c39d2f94eR10

tomli should not be required in Python 3.11, see https://github.com/PyCQA/bandit/pull/829#issuecomment-1062189424

mportesdev commented 2 years ago

@bersbersbers I agree, those two lines should not change, as Python 3.11 comes with the new tomllib module.

https://github.com/PyCQA/bandit/blob/main/bandit/core/config.py#L10

ericwb commented 2 years ago

@mportesdev @bersbersbers good catch, you are correct. Will remove.