Various non-code comments removed

PyCQA / eradicate

Removes commented-out code from Python files

https://pypi.python.org/pypi/eradicate

200 stars 24 forks source link

Various non-code comments removed #2

Closed The-Compiler closed 9 years ago

The-Compiler commented 9 years ago

I just tried out eradicate, and it removed those comments which aren't sourcecode:

# See # https://github.com/The-Compiler/qutebrowser/issues/263
# Qt >= 5.4 (okay, this one is probably hard to detect)
# anything (yet)
# configparser can't handle = in keys :(

myint commented 9 years ago

I've fixed the last case.

I think supporting the second and third will weaken the heuristic too much. The first one seems a bit odd. What is "See # URL"? Is that a typo for "See issue URL"?

Thanks

The-Compiler commented 9 years ago

Thanks!

Yeah, it was actually a typo - when moving the line after that upwards (with vim's J) I forgot to remove the #.