search

PyCon / pycon2019

Website for PyCon 2019
BSD 3-Clause "New" or "Revised" License
158 stars 89 forks source link

441 Display social login links #512

Closed dpoirier closed 9 years ago

dpoirier commented 9 years ago

These were in a sidebar on the login page, but the parent template had dropped the sidebar block. Worked out a way to get the content displayed roughly the same as last year with just changes to the login template and very minimal site.less changes.

Fixes #441

dchukhin commented 9 years ago

Looks mostly good so far; a few styling thoughts: -the h1 text "LOG IN" doesn't exactly line up with the h4 "SIGN IN WITH ANOTHER ACCOUNT" -the "Sign in with Google" and "Sign in with Yahoo!" lines are really close to each other

Also, trying to log in with Google gives me an error: 'Incorrect authentication service "google-oauth2"', but I'm guessing that's because I don't have the client id and secret?

dpoirier commented 9 years ago

@dchukhin I've reworked the styling and I think it's much improved.

You do need to have the google provider configured. Instructions here: https://github.com/PyCon/pycon/blob/73f5496aba4de81817c7627f3ba5877a7e3056c7/pycon/settings/base.py#L296

dchukhin commented 9 years ago

Excellent, styling looks much better! And Google login is successful for me. Another thing I noticed is that the same links show up at /account/associations/ Should we also update the styling on that page? (symposion/templates/social_auth/usersocialauth_list.html)

dpoirier commented 9 years ago

@dchukhin I've updated /account/associations/, please check it out.

dchukhin commented 9 years ago

:+1: