search

PyCon / pycon2019

Website for PyCon 2019
BSD 3-Clause "New" or "Revised" License
158 stars 89 forks source link

Addressed front end feedback from client review of the home page. #514

Closed rayt86 closed 9 years ago

rayt86 commented 9 years ago

I addressed the client feedback regarding the homepage including the motto and the rules above and below it. I also added SVG versions of the hills, city skyline, and footer trees to ensure that the color of the images matches the background color of the corresponding content. I also created smaller versions of the past pycon carousel images so they would load faster and eliminate the issue of the images not showing up when the carrousel had loaded.

dpoirier commented 9 years ago

On the home page, I'm still seeing faint lines where the color of the buildings is slightly different than the color of the background just below them, and the color of the trees near the bottom is slightly different from the footer background. (Chrome/Ubuntu/my non-color-adjusted monitor)

dpoirier commented 9 years ago

The colors match for the trees.

The buildings aren't showing up for me; I get a broken image for

    <img class="skyline" src="/2016/site_media/static/img/SVG/skyline.svg" width="100%" height="auto" alt="city of Portland, OR city skyline illustration">

Changing it to "Skyline.svg" appears to fix it, and then the building colors match the background underneath, so with that fix, :+1: