search

PyFixate / Fixate

Framework for hardware test fixtures and automatic test environments
MIT License
22 stars 16 forks source link

Revamp UI interactions #214

Open jcollins1983 opened 3 weeks ago

jcollins1983 commented 3 weeks ago

This PR addresses Issue #177 and Issue #213.

I've done a similar thing to the switching module and put the new _ui.py module at the fixate level and have only exposed the public functions.

To avoid having 2 different sets of functions in cmd_line.py and ui_gui_qt.py I moved the (duplicated) logic out of the UI files into ui.py and kept the original behaviour, tests were updated to deal with this change.

Also added the ability to have colour on user_info_important the line of ! defaults to red, which will hopefully be a bit more eye catching.

Have tested each of the functions manually. But should try on a real script or 2 before this gets merged if it does.

jcollins1983 commented 3 weeks ago

Looks like only the readthedocs build is done, no other tests? 🤔

image
jcollins1983 commented 3 weeks ago

This'll be why

image
jcollins1983 commented 3 weeks ago

This'll be why image

I'll do another targeted branch to fix this.

clint-lawrence commented 3 weeks ago

I haven't looked at the details here yet. General idea look fine.

This is what I'm thinking - there is probably a fair bit more we can/should do to improve. For example, tighten up typing to be more specific instead of many parameters/return values being strings. I don't want to get this improvement bogged down in trying to fix everything, but I don't want to shoot ourselves in the foot and complicate future improvements.

In any case, I'll get in and review this as is. And hopefully none of that is an issue.