PyHDI / Pyverilog

Python-based Hardware Design Processing Toolkit for Verilog HDL
Apache License 2.0
615 stars 172 forks source link

Proposed Fix bindvisitor.py #35

Open soffenberger opened 6 years ago

soffenberger commented 6 years ago

In dataflow/bindvisitor.py I am seeing an issue in getDsts where left is an Concat object instead of an LConcat object which looking at the code I posted below is just a matter of naming scheme. If you add the following change it will fix this issue and treat them as the same. This is happening when using a dataflow analyzer feel free to contact me to reproduce the error.

266 class Concat(Node): 267 attr_names = () 268 def init(self, list, lineno=0): 269 self.lineno = lineno 270 self.list = list 271 def children(self): 272 nodelist = [] 273 if self.list: nodelist.extend(self.list) 274 return tuple(nodelist) 275 class LConcat(Concat): pass

shtaxxx commented 6 years ago

Replacing the line 1277 is very easy, but I don't understand why such modification is required very well. Can you explain that?