`cffi` install fails on Windows 3.13

PyO3 / maturin-action

GitHub Action to install and run a custom maturin command with built-in support for cross compilation

MIT License

127 stars 35 forks source link

`cffi` install fails on Windows 3.13 #275

Closed davidhewitt closed 3 months ago

davidhewitt commented 3 months ago

Seen in https://github.com/pydantic/pydantic-core/actions/runs/9647421992/job/26606165701?pr=1340#step:8:38

It seems that cffi isn't released to work with 3.13 on Windows yet. We have https://github.com/python-cffi/cffi/pull/34 which has fixed the root cause but that's only on cffi main.

What's the preferred route here? Maybe cffi install can be optional?

messense commented 3 months ago

Ignoring the installation failure for the moment: https://github.com/PyO3/maturin-action/commit/f61caa214c9839739a727618c8965ae7282c2aa3, hopefully it will release it new version with 3.13 support soon.

davidhewitt commented 3 months ago

Confirmed working - thanks! https://github.com/pydantic/pydantic-core/pull/1346