refactor: :recycle: Use `typing_extensions` instead of `_typed_dict` - Githubissues

Pycord-Development / pycord

Pycord is a modern, easy to use, feature-rich, and async ready API wrapper for Discord written in Python

https://docs.pycord.dev

MIT License

2.74k stars 462 forks source link

refactor: :recycle: Use `typing_extensions` instead of `_typed_dict` #2621

Open Paillat-dev opened 4 weeks ago

Paillat-dev commented 4 weeks ago

Summary

Information

[x] This PR fixes an issue. fixes: #2166
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
[ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

[x] I have searched the open pull requests for duplicates.
[x] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes.
[ ] If type: ignore comments were used, a comment is also left explaining why.
[ ] I have updated the changelog to include these changes.

Paillat-dev commented 4 weeks ago

Does this need changelog ?

Dorukyum commented 1 week ago

Does this need changelog ?

Nope, just need to test if this works for typing_extensions 4.0.0 since that's the lowest allowed version in the requirements.

Paillat-dev commented 1 week ago

It does work, I will test again and merge master in here

Dorukyum commented 4 days ago

TypedDict has had changes after 4.0.0 (ref), we'd better test both older and newer versions.