Allow multiple values for header predicate

Pylons / pyramid

Pyramid - A Python web framework

https://trypyramid.com/

Other

3.98k stars 887 forks source link

Allow multiple values for header predicate #3576

Closed merwok closed 4 years ago

merwok commented 4 years ago

fixes #3575

[ ] validate wording in docstrings
[x] also edit narrative doc

merwok commented 4 years ago

Test failure is a sphinx issue that's certainly on master too

stevepiercy commented 4 years ago

@merwok see #3573 for docs failure. You can fix the lint failure in the meanwhile.

digitalresistor commented 4 years ago

I've kicked the Travis docs job, now that our docs are back online it should pass.

Oh, never mind, I see this is a Sphinx issue. Looks good here.

stevepiercy commented 4 years ago

@merwok docs build is succeeding now. When you get the time, would you please polish off the wording?

merwok commented 4 years ago

Yes I was subscribed to the docs PR, I can merge master and do the reword soon.

mmerickel commented 4 years ago

Thank you @merwok !

merwok commented 4 years ago

I wanted approval from @stevepiercy given that I didn’t take his wording suggestions 100% exactly, but all right! Glad you squash merged.

mmerickel commented 4 years ago

@merwok sounds good, in that case sorry about merging it too quickly - that being said I am happy with the feature and the state of the docs even if there's always room for improvement.

merwok commented 4 years ago

No worry!

merwok commented 4 years ago

Ah I misread the commit log, there was no squash merge but all my messy commits are in history now! Will rebase more swiftly next times.