search

Pythe1337N / garmin-connect

Makes it simple to interface with Garmin Connect to get or set any data point.
MIT License
144 stars 58 forks source link

Export UrlClass #65

Open dachia opened 10 months ago

dachia commented 10 months ago

Hi, @Pythe1337N

Thank you for this library.

There's an obvious use case to use custom requests, and IMHO it would make sense to export UrlClass for that purpose. I am using UrlClass, because you, as a maintainer, know better which URLs are possible. As an example, I had no idea of the GC_API URL until I looked at the source code.

Right now I am importing UrlClass directly like this import gcUrl from 'garmin-connect/dist/garmin/UrlClass.js'; which is very flaky.

Thank you for all your time and effort!

P.S. If you would prefer it, I can create PR for this

gregegan commented 8 months ago

@dachia - you can access these via GCClient

ie: GCClient.url.BASE_URL

gregegan commented 8 months ago

Mark as resolved @Pythe1337N