BUG: fix and add missing codes to the Slicer terminology file

QIICR / dcmqi

dcmqi (DICOM for Quantitative Imaging) is a free, open source C++ library for conversion between imaging research formats and the standard DICOM representation for image analysis results

https://qiicr.gitbook.io/dcmqi-guide/

BSD 3-Clause "New" or "Revised" License

242 stars 61 forks source link

BUG: fix and add missing codes to the Slicer terminology file #389

Closed fedorov closed 4 years ago

fedorov commented 4 years ago

This should resolve #388

fedorov commented 4 years ago

Thank you, I completely missed this as I was pasting items from the DICOM context file.

Now that I am reviewing it on this issue, I see only 11 structures have 3dSlicerIntegerLabel initialized. I think I should write a script to populate those items for all structures.

lassoan commented 4 years ago

@fedorov Are you going to send a pull request to update the files bundled with Slicer? https://github.com/Slicer/Slicer/tree/master/Modules/Loadable/Terminologies/Resources

fedorov commented 4 years ago

Indeed, I should do it. But I am not sure I will get to it today or tomorrow due to New Year.

lassoan commented 4 years ago

Thank you! It's not urgent, many people are on vacation these days anyway.