search

QMAPP-mq / qudi

A modular laboratory experiment management suite.
GNU General Public License v3.0
4 stars 0 forks source link

setting the M Squared wavelength no longer working #9

Closed mvbnano closed 6 years ago

mvbnano commented 6 years ago

What is affected by this bug?

Can no longer set the wavelength of the M Squared laser

When does this occur?

When you call laser_m2.set_wavelength

Where on the platform does it happen?

The error called from reading the JSON response, attempting to read the response with _read_response. It is caused because the response contains 2 messages - because a report is requested.

How do we replicate the issue?

laser_m2.set_wavelength

Expected behaviour (i.e. solution)

It should work.

Other Comments

We should not need to request a report for this action, instead just checking the status is sufficient. Prior to just not requesting a report, the original code needs to be checked for how it will be affected.

mvbnano commented 6 years ago

untested solution created on branch dev_m_squared_control

mvbnano commented 6 years ago

commit 130c5c712e5822d2519ad71236281287783334fd tested on branch dev_m_squared_control and is working. dev_m_squared_control will be merged into deployed_siv_upconversion