Add support for Thunderbird 91

fbezdeka commented 2 years ago

I'm on Fedora, which updated to TB 91 some days ago and this plugin stopped working.

I had to:

Synchronize with upstream highlight.js changes, especially update file names and synchronize styles
Fix the plain text mail detection (DOM seems to differ between TB versions)
Fix some style issues (due to different DOM layout some paddings/margin updates were necessary)
Fix the git signature detection (highlight.js seems to generate a different DOM now as well)

I'm not sure if this changes are fully backward compatible. It works for TB91 but I was not yet able to test later TB releases.

Outstanding topics:

The toolbar color button (disable highlighting) does not work (TB bug, https://bugzilla.mozilla.org/show_bug.cgi?id=1722065)

Feedback welcome.

Qeole commented 2 years ago

Looks like nice work, thanks a ton for diving into the code and fixing this! I'm just back from PTO and a little swamped today, but I'll try to look at this in more details as soon as I can.

fbezdeka commented 2 years ago

Take your time... I'm on vacation anyway and expecting a few review/test rounds.

Qeole commented 2 years ago

So we have this ongoing discussion on how to process the git version in the signature. Everything else looks good to me :+1:. Thanks for the changes :).

I forgot to mention the “deactivation/reactivation” thing yesterday: Given that it's a Thunderbird bug, let's just ignore that for now. We'll file an issue to document it and wait to see if the developers fix it in a reasonable time. I don't know for other people, but I don't use the feature often anyway.

Qeole / colorediffs

Add support for Thunderbird 91 #101