search

Qix- / color-convert

Plain color conversion functions in JavaScript
MIT License
746 stars 96 forks source link

hex #21

Closed TrySound closed 8 years ago

TrySound commented 9 years ago

It would be good to add hex conversion support.

MoOx commented 9 years ago

pr welcome :)

Qix- commented 8 years ago

What exactly do you mean by this? Like #FFFFFF to [255, 255, 255] and so on? Why not use hex-rgb? Not sure if the functionality here is really useful since it's a simple string/bit shift operation.

sindresorhus commented 8 years ago

:+1:

@Qix- For convenience. Also since we plan on using this in Chalk and I would like to be able to use hex colors with Chalk.

Qix- commented 8 years ago

Alright, I can add it in.

Qix- commented 8 years ago

Landed in 7234a9a7fbef3a4382a920eec19d6402675cac32. Thanks! :dancer:

TrySound commented 8 years ago

@Qix- Maybe also let to detect short notation like #fff ?