search

QtExcel / QXlsx

Excel file(*.xlsx) reader/writer library using Qt 5 or 6. Descendant of QtXlsxWriter.
https://qtexcel.github.io/QXlsx/
MIT License
1.16k stars 358 forks source link

CMake support #64

Open skypjack opened 4 years ago

skypjack commented 4 years ago

Hi there,

I'd like to include this library in a cmake based project. It would be great if QXlsx had also a CMakeLists.txt file to compile it as a target library rather than including directly its sources. Is there any plan to add it or would you accept a PR in this sense otherwise? Also, if you have any advise to make it work differently, please drop a line here. It would be appreciated.

j2doll commented 4 years ago

Dear @skypjack

There are no plans to apply cmake for versions of QXlsx that use Qt5.

But the new Qt6 technology vision recommends using cmake as the main build method. Qt6 is expected to be released by the end of 2020, and cmake will be required to use QXlsx in Qt6.

I will register this issue as an enhancement. Thank you for your report.

skypjack commented 4 years ago

Nvm. I can wait. In the meantime I'm using cmake's external project to download, build and add this project when needed. Thanks for answering. :+1:

laurennlam commented 4 years ago

Hi, I just pushed a new branch with a CMakeLists. You'll find it here : https://github.com/QtExcel/QXlsx/pull/72

KangLin commented 4 years ago

@j2doll Please merge #106

j2doll commented 4 years ago

Dear @KangLin

Sorry for the late reply. I'm currently working on a commercial project where internet use is restricted. Internet is only available on weekends. The environment without internet is more serious than Corona.

DarthGandalf commented 3 years ago

Hi, why did you delete CMakeLists.txt? In c8ca4f5bba5ae8a16b5bbdbaba3ba6df094949fa

DarthGandalf commented 3 years ago

Nvm, I got confused, it's now in QXlsx/ subdirectory