search

QuTech-Delft / qx-simulator

QX Simulator
Other
16 stars 12 forks source link

Replace submodules by CMake's FetchContent mechanism #131

Closed mmoelle1 closed 1 year ago

mmoelle1 commented 1 year ago

Dear QX developers,

may I suggest to replace the git submodules in the deps directory by CMake's FetchContent mechanism. It is as easy as potting the following code snippet into your CMakeLists.txt file

include(FetchContent) FetchContent_Declare(openql URL https://github.com/QuTech-Delft/OpenQL/archive/refs/tags/v0.11.1.zip )

Here you can set Make variables if needed

FetchContent_MakeAvailable(openql) FetchContent_GetProperties(openql) include_directories(${openql_SOURCE_DIR}/include) This will download the archive, unpack it, and configure it to be used within the CMake project.

The problem with the current submodule approach is that tar.gz and zip archives of qx-simulator are basically unusable due to the missing and not-obtainable submodule dependencies.

pablolh commented 1 year ago

@rturrado has been working on this and it will be fixed soon

pablolh commented 1 year ago

Done