search

QuTech-Delft / qx-simulator

QX Simulator
Other
16 stars 12 forks source link

QX only opened a qasm file, this closes it. #93

Closed anneriet closed 2 years ago

anneriet commented 3 years ago

I kept getting a "too many open files" error when running qxelerator tests, so I took a look into the source code and found out that the qasm files weren't being closed. This should fix that, my tests don't give the error anymore and the open qasm file is not used after parsing anyway.

pablolh commented 2 years ago

I fixed it too in https://github.com/QuTech-Delft/qx-simulator/pull/96

pablolh commented 2 years ago

Anneriet feel free to review https://github.com/QuTech-Delft/qx-simulator/pull/96, I couldn't find you in the possible reviewers list

jvansomeren commented 2 years ago

There are unresolved comment from Fer and some request to Anneriet.

pablolh commented 2 years ago

This is resolved by https://github.com/QuTech-Delft/qx-simulator/pull/96