search

QuTech-Delft / qx-simulator

QX Simulator
Other
16 stars 12 forks source link

Modernizing and cleaning up code #96

Closed pablolh closed 2 years ago

pablolh commented 2 years ago

This rather large PR makes QX-simulator's code better:

pablolh commented 2 years ago

This PR does not change functionality indeed. It is a much needed cleanup and code update.

pablolh commented 2 years ago

Can we please merge this? I have more changes on top of that that are requested by Quantum Inspire and that I'd like to merge as well.

RichardVersluisTNO commented 2 years ago

For me it is perfectly fine to merge

Richard

From: Pablo Le Hénaff @.> Sent: dinsdag 18 oktober 2022 11:56 To: QuTech-Delft/qx-simulator @.> Cc: Versluis, R. (Richard) @.>; Review requested @.> Subject: Re: [QuTech-Delft/qx-simulator] Modernizing and cleaning up code (PR #96) Importance: Low

Can we please merge this? I have more changes on top of that that are requested by Quantum Inspire and that I'd like to merge as well.

— Reply to this email directly, view it on GitHubhttps://github.com/QuTech-Delft/qx-simulator/pull/96#issuecomment-1282133099, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AECY6I5WF6HHD4Y7B5NN7NDWDZX2LANCNFSM6AAAAAAQVQWA54. You are receiving this because your review was requested.Message ID: @.***> This message may contain information that is not intended for you. If you are not the addressee or if this message was sent to you by mistake, you are requested to inform the sender and delete the message. TNO accepts no liability for the content of this e-mail, for the manner in which you use it and for damage of any kind resulting from the risks inherent to the electronic transmission of messages.

pablolh commented 2 years ago

Cool, it still needs approval to be merged as far as I can see

jvansomeren commented 2 years ago

Ok, merge it.