This pull request addresses the issue related to the subscription on the trade channel in different Binance markets. The changes made in this PR ensure that the correct trade channel is utilized for streaming trade information.
Related Issue
Closes #31
Closes #28
Motivation and Context
The existing implementation uses the default trade channel for streaming trade data, which may not be suitable for all scenarios. This pull request introduces a fix to allow users to specify the trade channel based on the Binance market they are interested in. The motivation behind this change is to provide flexibility in choosing the appropriate trade channel, enhancing the usability of the codebase.
Requires Documentation Change
Yes. The XML documentation for the TradeChannel property has been updated to reflect its purpose, default value, and the context in which it is used. Additionally, documentation for the overridden TradeChannelName property has been added, providing information about the specific trade channel used in this context.
How Has This Been Tested?
This change has been tested by manually subscribing to trade channels in different Binance markets, verifying that the correct trade channel is utilized based on the provided market information.
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Refactor (non-breaking change which improves implementation)
[ ] Performance (non-breaking change which improves performance. Please add associated performance test and results)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
This pull request addresses the issue related to the subscription on the trade channel in different Binance markets. The changes made in this PR ensure that the correct trade channel is utilized for streaming trade information.
Related Issue
Closes #31 Closes #28
Motivation and Context
The existing implementation uses the default trade channel for streaming trade data, which may not be suitable for all scenarios. This pull request introduces a fix to allow users to specify the trade channel based on the Binance market they are interested in. The motivation behind this change is to provide flexibility in choosing the appropriate trade channel, enhancing the usability of the codebase.
Requires Documentation Change
Yes. The XML documentation for the TradeChannel property has been updated to reflect its purpose, default value, and the context in which it is used. Additionally, documentation for the overridden TradeChannelName property has been added, providing information about the specific trade channel used in this context.
How Has This Been Tested?
This change has been tested by manually subscribing to trade channels in different Binance markets, verifying that the correct trade channel is utilized based on the provided market information.
Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>