search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

description meta tags - issue 287 #293

Closed AakashGfude closed 5 years ago

AakashGfude commented 5 years ago

Added a description tag on the submission pages. the MetaTags.jsx component only has description meta tag at present, we can add more tags which needs to be dynamically updated.

AtlasMaxima-zz commented 5 years ago

@AakashGfude @mmcky I just tested some of the notebook summary and also looked into the meta tags when the notebooks are generated from our development site. And the meta tags are capturing other descriptions like keywords or the content or the summary descriptions only the title.

screen shot 2018-12-12 at 3 32 22 pm

Can we also add meta tags for keywords for each notebooks and/or add meta tags for the summary description for the notebook? Something like this:

screen shot 2018-12-12 at 3 31 26 pm

Also, I think it would be helpful if we can add meta tags for the home page as well with keywords when people are searching it on google search and a short description meta tag on what the platform is about.

AakashGfude commented 5 years ago

The description meta tag capture4

meta description is also getting generated. Yes you are right, we can add more meta tags. MetaTag component can be used to write any additional dynamic meta tags. For static ones we can put them directly in the html file.

The above pic is of development site.

AtlasMaxima-zz commented 5 years ago

@AakashGfude Thank you for your inputs. I missed the meta tags after all the script tags. Can you please liase with @jstac or @mmcky on what static meta tags we would like to put for the QuantEcon notebook itself. Please let me know after these new tags have been added and I can review and merge with master.

AakashGfude commented 5 years ago

@AtlasMaxima Good Idea. @jstac , @mmcky your inputs on this? Also, I just realized, we are updating the title tag directly from Submission.jsx dynamically, will move that code to MetaTag component for consistency. Speaking about the script tags in the head component, if they are not analytics and those kind of scripts which needs to be in the head, it is best to write them just before the end of body tag to prevent render blocking. I will do that in a separate branch later, which we can use for rendering optimizations like this.

jstac commented 5 years ago

Thanks @AakashGfude @AtlasMaxima

@mmcky , would you mind to make some suggestions on tags?

mmcky commented 5 years ago

hey @AakashGfude and @AtlasMaxima. Sorry I have diverted github notification in my email to a folder so I missed this. When you make a PR would you mind sending me a slack link. Thanks.

Is this the keywords associated with the site that we discussed yesterday? quantitative economics, computational economics, jupyter, forum

mmcky commented 5 years ago

thanks @AakashGfude. @AtlasMaxima if you're happy with this PR please merge. Thanks.

AakashGfude commented 5 years ago

Closes #287