search

QuantEcon / Bookshelf

Code for the site QuantEconLib
1 stars 0 forks source link

FEAT: delete comment #325

Closed AakashGfude closed 5 years ago

AakashGfude commented 5 years ago

Delete comment feature has been added and it should adhere to frontend /UI synchronization. Works for main comments as well as replies.

At present, deleting the parent comment will automatically delete the child comments as well.

HAVE PUSHED TO DEVELOPMENT FOR TESTING

The present UI is a simple no-brainer implementation :-

deletecomment

modaldeletecomment

Side note for developers:-

Since files inside assets/css directory was always appearing in git changes, and we do not want it as it should be compiled in local environment. I have put it in .gitignore. Even after this, git was still tracking it because of its cache. so have cleared the cache for git to start ignoring that file. Because of the clearing of cache, you might see a lot of files being committed. That is a part of the drill. I think it should not cause any issues.

fixes #261

mmcky commented 5 years ago

thanks @AakashGfude just had a quick test on the development instance. So just to be clear the rule of thumb is if a comment is deleted then all child comments are also deleted?

AakashGfude commented 5 years ago

@mmcky yes, I had done that for now. As I assumed that the child comments will most probably be direct replies to the parent comment and won't make much sense without the parent one.

But if we get other scenarios as well, then we can decide on something else.

Wrote this functionality in the description of the PR. Thanks for pointing out.

mmcky commented 5 years ago

thanks @AakashGfude