search

Quantco / datajudge

Assessing whether data from database complies with reference information.
https://datajudge.readthedocs.io
BSD 3-Clause "New" or "Revised" License
42 stars 3 forks source link

Bump codecov/codecov-action from 3.1.3 to 4.5.0 #236

Closed dependabot[bot] closed 4 months ago

dependabot[bot] commented 5 months ago

Bumps codecov/codecov-action from 3.1.3 to 4.5.0.

Release notes

Sourced from codecov/codecov-action's releases.

v4.5.0

What's Changed

New Contributors

Full Changelog: https://github.com/codecov/codecov-action/compare/v4.4.1...v4.5.0

v4.4.1

What's Changed

New Contributors

Full Changelog: https://github.com/codecov/codecov-action/compare/v4.4.0...v4.4.1

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from codecov/codecov-action's changelog.

4.0.0-beta.2

Fixes

  • #1085 not adding -n if empty to do-upload command

4.0.0-beta.1

v4 represents a move from the universal uploader to the Codecov CLI. Although this will unlock new features for our users, the CLI is not yet at feature parity with the universal uploader.

Breaking Changes

  • No current support for aarch64 and alpine architectures.
  • Tokenless uploading is unsuported
  • Various arguments to the Action have been removed

3.1.4

Fixes

  • #967 Fix typo in README.md
  • #971 fix: add back in working dir
  • #969 fix: CLI option names for uploader

Dependencies

  • #970 build(deps-dev): bump @​types/node from 18.15.12 to 18.16.3
  • #979 build(deps-dev): bump @​types/node from 20.1.0 to 20.1.2
  • #981 build(deps-dev): bump @​types/node from 20.1.2 to 20.1.4
Commits
  • e28ff12 chore(release): bump to 4.5.0 (#1477)
  • 7594baa Use an existing token even if the PR is from a fork (#1471)
  • 81c0a51 feat: add support for tokenless v3 (#1410)
  • f5e203f build(deps-dev): bump @​typescript-eslint/eslint-plugin from 7.12.0 to 7.13.0 ...
  • 7c48363 build(deps-dev): bump braces from 3.0.2 to 3.0.3 (#1475)
  • 69e5d09 build(deps-dev): bump @​typescript-eslint/parser from 7.12.0 to 7.13.0 (#1474)
  • feaf700 fix: handle trailing commas (#1470)
  • 7b6a727 build(deps): bump github/codeql-action from 3.25.7 to 3.25.8 (#1472)
  • ccf7a1f build(deps-dev): bump @​typescript-eslint/eslint-plugin from 7.11.0 to 7.12.0 ...
  • f03f015 build(deps-dev): bump @​typescript-eslint/parser from 7.11.0 to 7.12.0 (#1467)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
pavelzw commented 5 months ago

i think codecov-action 4 needs an explicit token in the secrets 🤔

ivergara commented 5 months ago

Let's merge for now.

pavelzw commented 5 months ago

nope, we need to set the secrets, otherwise the upload will fail

image
ivergara commented 5 months ago

Fine, I guess this is something @kklein has to take a look at.

Thanks.

pavelzw commented 5 months ago

you can find the token at https://app.codecov.io/gh/quantco/datajudge/settings and should set it both as an actions secret and a dependabot secret secrets.CODECOV_TOKEN.

kklein commented 4 months ago

I added both and afaict we still obtain the same error. :/

xhochy commented 4 months ago

I added both and afaict we still obtain the same error. :/

Did you also add it as a Dependabot secret? ;)

kklein commented 4 months ago

Afaict yes: Screenshot 2024-07-03 at 2 25 59 PM

pavelzw commented 4 months ago

a274e85 (#236) should fix it

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.35%. Comparing base (a935d64) to head (421ed10). Report is 75 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== + Coverage 91.63% 93.35% +1.71% ========================================== Files 18 18 Lines 1985 1985 ========================================== + Hits 1819 1853 +34 + Misses 166 132 -34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pavelzw commented 4 months ago

HEAD has 30 uploads less than BASE

Not sure if codecov is just being flaky or if this is an actual issue

xhochy commented 4 months ago

HEAD has 30 uploads less than BASE

I wouldn't worry too much about this until we have merged this PR to main.

pavelzw commented 4 months ago

HEAD having 21 should be fine. BASE having 51 seems like an irregularity with codecov 3

also this seems odd

Report is 67 commits behind head on main.

but i agree that we should just merge and check if the issue occurs in follow-up PRs